New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding PIMF php micro framework #812
Conversation
…mf #php #framework
hello??? |
@gjerokrsteski We are busy processing round 9; we will take a look at pull requests after that effort has been concluded. |
OK, thank you ;-) |
I tried to run your framework and I got the error message "The requested package gjerokrsteski/pimf-framework could not be found in any version" from when we try to download the data from composer. I looked through the packages and found one without the -framework so I tried that one and I'm still getting the same message that it can not be found. |
@mcocciaTE I just added the right version of PHP for Composer. That should work fine. Please check it out agin. |
That change did not fix the problem of "The requested package gjerokrsteski/pimf-framework could not be found in any version" but I ended up commenting out subprocess.check_call("composer.phar install --optimize-autoloader", shell=True, cwd="php-pimf") and the rest of the code ran perfectly fine without errors. However the tests failed because your output was {"id":4286,"randomnumber":605} where it should be in the form of {"id":3217,"randomNumber":2149} stated here http://www.techempower.com/benchmarks/#section=code&hw=peak&test=json |
Ahh OK! That is a good idea. I fix the DB connector that forced all db-drivers to use lower-case. Please test it again. Thank you :-) |
I ran the test again and everything passed! And then I saw you had a pimf_raw test. I got most of the pimf_raw tests working by just routing nginx_raw.conf to index.php instead of a nonexistant (that I can find) index_raw.php except I am having issues with the fortunes test. The rules state that the result must be ordered by message instead of ID, which should be just running a sort method on the fortunes except I am not familiar at all with PHP and what I pulled from google hasn't been working. I tried running usort on fortunes like this https://gist.github.com/mcocciaTE/65a24e318af7b4339b26 but I am just getting internal server errors. :( Once we get that working though I can merge and close this PR! |
@mcocciaTE Thank you for the pleasant advice. :-) I fixed and pushed it already. Now, the result is ordered by "message". Please check it again ;-) |
@mcocciaTE The sorting happens now at the controller. 👍 |
Dear TechEmpower team, I just added a new PHP micro framework "PIMF" for benchmarking. Please give me a feedback if all is well configured.
Thank you :-)